Fall back to http when websockets fail#10139
Merged
pakrym-oai merged 4 commits intomainfrom Jan 29, 2026
Merged
Conversation
Rename connection_manager module and related fields/methods to transport_manager, updating imports, exports, tests, and ModelClient/Session plumbing to use TransportManager consistently.
pakrym-oai
commented
Jan 29, 2026
| fallback_to_http: Arc<AtomicBool>, | ||
| } | ||
|
|
||
| impl TransportManager { |
Collaborator
Author
There was a problem hiding this comment.
not in love with this single field class that has to be dragged everywhere but we need a bit that is persisted throughout the session
aibrahim-oai
approved these changes
Jan 29, 2026
Add otel counter for websocket transport fallbacks to HTTP and emit a user-facing warning event when switching transports after exceeding stream retry budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect not all proxies work with websockets, fall back to http if websockets fail.