feat: vendor app-server protocol schema fixtures #10371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
changed the title
bolinfest
force-pushed
the
pr10371
branch
3 times, most recently
from
dfdf5e9 to
5be57b4
Compare
Motivation: - `codex-app-server-protocol` schema fixtures are not insta snapshots. - Filtering `*.snap.new` is confusing and risks hiding real files. What changed: - Remove the `.snap.new` filename special case in `read_schema_fixture_tree`. Refs: macOS Bazel schema fixture mismatch investigation
pakrym-oai
approved these changes
Feb 2, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what @sayan-oai did in #8956 for
config.schema.json, this PR updates the repo so that it includes the output ofcodex app-server generate-json-schemaandcodex app-server generate-tsand adds a test to verify it is in sync with the current code.Motivation:
codex-rs/app-server-protocol/tests/schema_fixtures.rswas added as the test andjust write-app-server-schemacan be use to generate the vendored schema files.Incidentally, when I run:
I see a number of
snake_casenames that should becamelCase.