Conversation
aibrahim-oai
changed the title
| params: v2::ThreadUnarchiveParams, | ||
| response: v2::ThreadUnarchiveResponse, | ||
| }, | ||
| ThreadCompact => "thread/compact" { |
There was a problem hiding this comment.
can we call this thread/compact/start? this will be more in line with turn/start and review/start that kick off a turn + items.
| }, | ||
| ThreadCompact => "thread/compact" { | ||
| params: v2::ThreadCompactParams, | ||
| response: v2::ThreadCompactResponse, |
There was a problem hiding this comment.
then these can be ThreadCompactStartParams and ThreadCompactStartResponse
codex-rs/app-server/README.md
Outdated
|
|
||
| ### Example: Trigger thread compaction | ||
|
|
||
| Use `thread/compact` to trigger manual history compaction for a thread. The request returns immediately, and you can observe progress via standard `turn/*` and `item/*` notifications. |
There was a problem hiding this comment.
Should the client only expect a turn with a single compaction item? If so, worth making it a bit more clear in the docs here.
There was a problem hiding this comment.
Is compaction asynchronous?
There was a problem hiding this comment.
it's async thread manager wise but blocks threads
There was a problem hiding this comment.
so if that is the case do we want to return right away? cause otherwise folks will think that their instance is stuck depending on duration of the compaction.
|
@codex fix ci |
|
Summary
Testing
|
aibrahim-oai
force-pushed
the
codex/thread-compact-v2-pr
branch
from
87d082d to
bc29761
Compare
3 participants
thread/compactas a trigger-only v2 RPC that submitsOp::Compactand returns{}immediately.