Skip to content

Ignore remote_compact_trims_function_call_history_to_fit_context_window on windows #10474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pakrym-oai merged 1 commit into from
Feb 3, 2026
Merged

Ignore remote_compact_trims_function_call_history_to_fit_context_window on windows #10474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codex-rs/core/tests/suite/compact_remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ async fn remote_compact_runs_automatically() -> Result<()> {
Ok(())
}

#[cfg_attr(target_os = "windows", ignore)]
Copy link
Collaborator

@bolinfest bolinfest Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this doesn't cause any unused import clippy warnings on Windows?

Copy link
Collaborator Author

@pakrym-oai pakrym-oai Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just adds an attribute, it doesn't remove the entire method. In theory it shouldn't affect imports.

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn remote_compact_trims_function_call_history_to_fit_context_window() -> Result<()> {
skip_if_no_network!(Ok(()));
Expand Down
Loading