Skip to content

Allow user shell commands to run alongside active turns#10513

Merged
jif-oai merged 4 commits intomainfrom
jif/user-shell-cmd-async
Feb 5, 2026
Merged

Allow user shell commands to run alongside active turns#10513
jif-oai merged 4 commits intomainfrom
jif/user-shell-cmd-async

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Feb 3, 2026

Summary

  • refactor user shell command execution into a shared helper and add modes for standalone vs active-turn execution
  • run user shell commands asynchronously when a turn is already active so they don’t replace or abort the current turn
  • extend the tests to cover the new behavior and add the generated Codex environment manifest

Testing

  • Not run (not requested)

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 3, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8622225ae8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Feb 3, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdd699ef07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 97582ac into main Feb 5, 2026
30 of 32 checks passed
@jif-oai jif-oai deleted the jif/user-shell-cmd-async branch February 5, 2026 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments