Skip to content

Avoid redundant transactional check before inserting dynamic tools#10521

Merged
jif-oai merged 1 commit intomainfrom
jif/flaky-dyn-tool
Feb 3, 2026
Merged

Avoid redundant transactional check before inserting dynamic tools#10521
jif-oai merged 1 commit intomainfrom
jif/flaky-dyn-tool

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Feb 3, 2026

Summary

  • remove the extra transaction guard that checked for existing dynamic tools per thread before inserting new ones
  • insert each tool record with ON CONFLICT(thread_id, position) DO NOTHING to ignore duplicates instead of pre-querying
  • simplify execution to use the shared pool directly and avoid unneeded commits

Testing

  • Not run (not requested)

@jif-oai jif-oai merged commit ed778f9 into main Feb 3, 2026
34 of 38 checks passed
@jif-oai jif-oai deleted the jif/flaky-dyn-tool branch February 3, 2026 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant