Skip to content

Conversation

@charley-oai
Copy link
Collaborator

Summary

This PR updates the request_user_input TUI overlay so Esc is context-aware:

  • When notes are visible for an option question, Esc now clears notes and exits notes mode.
  • When notes are not visible (normal option selection UI), Esc still interrupts as before.

It also updates footer guidance text to match behavior.

Changes

  • Added a shared notes-clear path for option questions:
    • Tab and Esc now both clear notes and return focus to options when notes are visible.
  • Updated footer hint text in notes-visible state:
    • from: tab to clear notes | ... | esc to interrupt
    • to: tab or esc to clear notes | ...
  • Hid esc to interrupt hint while notes are visible for option questions.
  • Kept esc to interrupt visible and functional in normal option-selection mode.
  • Updated tests to assert the new Esc behavior in notes mode.
  • Updated snapshot output for the notes-visible footer row.
  • Updated docs in docs/tui-request-user-input.md to reflect mode-specific Esc behavior.

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai enabled auto-merge (squash) February 4, 2026 00:14
@charley-oai charley-oai disabled auto-merge February 4, 2026 00:17
@charley-oai charley-oai merged commit a9eb766 into main Feb 4, 2026
31 checks passed
@charley-oai charley-oai deleted the request-user-input-ui-nit branch February 4, 2026 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants