Fix jitter in TUI apps/connectors picker #10593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvrno-oai
force-pushed
the
canvrno/tui_apps_menu_jitter
branch
from
fbc37f9 to
550d378
Compare
joshka-oai
approved these changes
Feb 4, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes jitter in the TUI apps menu by making the description column stable during rendering and height measurement.
Added a
stable_desc_coloption toSelectionViewParams/ListSelectionView, introduced stable variants of the shared row render/measure helpers inselection_popup_common, and enabled the stable mode for the apps/connectors picker inchatwidget. With these changes, only the apps/connectors picker uses this new option, though it could be used elsewhere in the future.Why: previously, the description column was computed from only currently visible rows, so as you scrolled or filtered, the column could shift and cause wrapping/height changes that looked jumpy. Computing it from all rows in this popup keeps alignment and layout consistent as users scroll through avaialble apps.
Before:
https://github.com/user-attachments/assets/3856cb72-5465-4b90-a993-65a2ffb09113
After:
https://github.com/user-attachments/assets/37b9d626-0b21-4c0f-8bb8-244c9ef971ff