Skip to content

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Feb 4, 2026

Summary

  • add shared ModeKind helpers for display names, TUI visibility, and request_user_input availability
  • derive TUI mode filtering/labels from shared ModeKind metadata instead of local hardcoded matches
  • derive request_user_input availability text and unavailable error mode names from shared mode metadata
  • replace hardcoded known mode names in the Default collaboration-mode template with {{KNOWN_MODE_NAMES}} and fill it from TUI_VISIBLE_COLLABORATION_MODES
  • add regression tests for mode metadata sync and placeholder replacement

Notes

  • cargo test -p codex-core integration target (tests/all) still shows pre-existing env-specific failures in this environment due missing test_stdio_server binary resolution; core unit tests are green.

Codex author

codex resume 019c26ff-dfe7-7173-bc04-c9e1fff1e447

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit 41b4962 into main Feb 5, 2026
32 checks passed
@charley-oai charley-oai deleted the slightly-tweak-modes-prompt branch February 5, 2026 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants