Add app-server transport layer with websocket support #10693
Conversation
maxj-oai
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cd76800f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let outgoing_message = | ||
| OutgoingMessage::Request(request.request_with_id(outgoing_message_id.clone())); | ||
| if let Err(err) = self.sender.send(outgoing_message).await { | ||
| if let Err(err) = self | ||
| .sender | ||
| .send(OutgoingEnvelope::Broadcast { | ||
| message: outgoing_message, | ||
| }) |
There was a problem hiding this comment.
With websocket support, send_request_with_id now broadcasts server-initiated requests (approvals, user input, auth refresh) to all initialized connections, and the first response wins while other responses are dropped. This means a second client can receive and approve/deny a command or tool call that was triggered by a different client, causing cross-connection data leakage and incorrect approvals. These requests should be targeted to the connection that initiated the action (e.g., carry a ConnectionId through the request flow) instead of broadcasting.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is intentional - all connected clients are eligible to receive / reply to requests from server->client
JaviSoto
left a comment
JaviSoto
left a comment
There was a problem hiding this comment.
Not super familiar with the code, so someone else should take a look. It looks good to me overall. I particularly like the --listen stdio://|ws://IP:PORT API! 🙏
Lazy question: are the changes to the app-server messages you made backwards compatible? Just wanna make sure that existing clients don't break
|
@JaviSoto this doesn't change any of the app-server messages yet - just allows multiple connections and broadcast + response routing semantics |
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
approving to unblock, i think the experimental thing we can figure out as a followup
4 participants
Testing