Skip to content

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Feb 7, 2026

Fixes a line ending that was altered in #10861.

This is breaking the release due to:

cargo run -p codex-core --bin codex-write-config-schema
git diff --exit-code core/config.schema.json

This PR updates the test to check for this so we should catch it in CI (or when running tests locally):

#[test]
fn config_schema_matches_fixture() {
let fixture_path = codex_utils_cargo_bin::find_resource!("config.schema.json")
.expect("resolve config schema fixture path");
let fixture = std::fs::read_to_string(fixture_path).expect("read config schema fixture");
let fixture_value: serde_json::Value =
serde_json::from_str(&fixture).expect("parse config schema fixture");
let schema_json = config_schema_json().expect("serialize config schema");
let schema_value: serde_json::Value =
serde_json::from_slice(&schema_json).expect("decode schema json");
let fixture_value = canonicalize(&fixture_value);
let schema_value = canonicalize(&schema_value);
if fixture_value != schema_value {
let expected =
serde_json::to_string_pretty(&fixture_value).expect("serialize fixture json");
let actual =
serde_json::to_string_pretty(&schema_value).expect("serialize schema json");
let diff = TextDiff::from_lines(&expected, &actual)
.unified_diff()
.header("fixture", "generated")
.to_string();
panic!(
"Current schema for `config.toml` doesn't match the fixture. \
Run `just write-config-schema` to overwrite with your changes.\n\n{diff}"
);
}
}

@bolinfest bolinfest enabled auto-merge (squash) February 7, 2026 06:30
@bolinfest bolinfest disabled auto-merge February 7, 2026 06:30
@bolinfest bolinfest merged commit 18bb255 into main Feb 7, 2026
52 of 62 checks passed
@bolinfest bolinfest deleted the pr10977 branch February 7, 2026 06:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants