Skip to content

app-server: treat null mode developer instructions as built-in defaults#10983

Merged
charley-oai merged 2 commits intomainfrom
fix/app-server-collab-null-default-instructions
Feb 7, 2026
Merged

app-server: treat null mode developer instructions as built-in defaults#10983
charley-oai merged 2 commits intomainfrom
fix/app-server-collab-null-default-instructions

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Feb 7, 2026

Summary

  • make turn/start normalize collaborationMode.settings.developer_instructions: null to the built-in instructions for the selected mode
  • prevent app-server clients from accidentally clearing mode-switch developer instructions by sending null
  • document this behavior in the v2 protocol and app-server docs

What changed

  • codex-rs/app-server/src/codex_message_processor.rs
    • added a small normalize_turn_start_collaboration_mode helper
    • in turn_start, apply normalization before OverrideTurnContext
  • codex-rs/app-server/tests/suite/v2/turn_start.rs
    • extended turn_start_accepts_collaboration_mode_override_v2 to assert the outgoing request includes default-mode instruction text when the client sends developer_instructions: null
  • codex-rs/app-server-protocol/src/protocol/v2.rs
    • clarified TurnStartParams.collaboration_mode docs: settings.developer_instructions: null means use built-in mode instructions
  • regenerated schema fixture:
    • codex-rs/app-server-protocol/schema/typescript/v2/TurnStartParams.ts
  • docs:
    • codex-rs/app-server/README.md
    • codex-rs/docs/codex_mcp_interface.md

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit e6662d6 into main Feb 7, 2026
32 checks passed
@charley-oai charley-oai deleted the fix/app-server-collab-null-default-instructions branch February 7, 2026 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments