Fixed bug in file watcher that results in spurious skills update events and large log files#11217
Merged
etraut-openai merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
On some platforms, the "notify" file watcher library emits events for file opens and reads, not just file modifications or deletes. The previous implementation didn't take this into account. Furthermore, the `tracing.info!` call that I previously added was emitting a lot of logs. I had assumed incorrectly that `info` level logging was disabled by default, but it's apparently enabled for this crate. This is resulting in large logs (hundreds of MB) for some users.
etraut-openai
changed the title
etraut-openai
changed the title
pakrym-oai
approved these changes
Feb 9, 2026
xl-openai
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms, the "notify" file watcher library emits events for file opens and reads, not just file modifications or deletes. The previous implementation didn't take this into account.
Furthermore, the
tracing.info!call that I previously added was emitting a lot of logs. I had assumed incorrectly thatinfolevel logging was disabled by default, but it's apparently enabled for this crate. This is resulting in large logs (hundreds of MB) for some users.