-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix pre-turn compaction context handling and remote compact edge cases #11234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
2d4123c
Fix model switch compaction
charley-oai a79bebe
Simplify
charley-oai c7cef7d
update snapshot
charley-oai 5c389f9
Update pre-sampling model-switch compaction snapshot
charley-oai e0f99eb
compact: split core logic changes from snapshot test coverage
charley-oai 4022de7
compact: preserve incoming items during pre-turn trim retries
charley-oai e87455e
codex: persist pre-turn updates when compaction fails
charley-oai 8d06dd5
Persist pre-turn updates before apps tool-list cancellation
charley-oai 36499b5
Reinject canonical context for model-switch pre-turn compaction
charley-oai 59d3431
Fix clippy useless_vec in compact_remote test
charley-oai 2a804d9
Update snaps
charley-oai 8b2f506
update snaps
charley-oai 15730c2
Align compaction tests with incoming-item and empty-history behavior
charley-oai c92190f
Avoid wildcard pattern in ResponseEvent::Completed match
charley-oai bddd53b
Rebase: align compaction snapshots and imports
charley-oai d9b02b6
Differentiate model-switch compaction failures from oversize input
charley-oai ce77778
Enable compaction tests and remove stale TODO markers
charley-oai 9e6ef13
Add comment
charley-oai b7b50d6
Add TODO for legacy compacted history context reinjection
charley-oai 5682f72
Move previous-model compact failure handling into helper
charley-oai e3efe3a
Return sentinel error from model-switch compaction helper
charley-oai 8595664
Move pre-turn auto-compact error handling into helper
charley-oai de959aa
Comments
charley-oai 54e606a
Comment
charley-oai 3a04f2c
Use explicit user-message predicate for compaction filtering
charley-oai f832de6
Document manual compact turn-context reinjection policy
charley-oai b029cc2
Reinject context for summary-only compacted history
charley-oai 466c689
compact: reinsert context above last summary
charley-oai 5929f05
compact: snapshot reinjection above last summary
charley-oai b5aeb30
compact: strip incoming model-switch before compaction
charley-oai 9d34abf
core: snapshot pre-turn model-switch compaction strip behavior
charley-oai 7139784
Strip incoming model-switch updates from remote compaction input
charley-oai d81d89a
Silence interrupted pre-turn compaction failures
charley-oai f7956ff
Persist pre-turn updates before interrupted model-switch compact exits
charley-oai ccc2700
Persist pre-turn updates before interrupted auto-compaction exits
charley-oai 3f2f817
Make compact unit snapshots Bazel-stable
charley-oai 907e292
Add comment
charley-oai 04b157b
Treat no-op pre-turn compaction as not-needed
charley-oai a38b1c9
Move compact reinjection snapshots into suite coverage
charley-oai 15aa101
Qualify Feature enum in compact suite tests
charley-oai 3964bec
dd comment
charley-oai 589b076
Fix compact test snapshot and include bazel lock update
charley-oai 01794f1
Reuse compaction keep filter for incoming items
charley-oai 6e6e718
Use real user predicate for compaction reinjection
charley-oai afebfff
Exclude user shell command records from compaction keep set
charley-oai 4c2c861
Keep shell command records only in incoming compaction items
charley-oai d53b588
Base incoming compaction filtering on keep predicate
charley-oai 52e6a54
Define real user predicate independent of keep policy
charley-oai 8b290e8
Drop redundant summary check for incoming compaction items
charley-oai 80ab62f
cleanup
charley-oai 6663b69
Restrict compacted-history keep set to user and compaction items
charley-oai b781a15
Keep only user+compaction items in compacted history
charley-oai 0d796c7
Keep shell command records in compacted history filter
charley-oai a9c6219
Append incoming pre-turn items after compaction summary
charley-oai 868019d
Skip mid-turn compaction error event on interruption
charley-oai 583dee0
Refactor remote compaction incoming-item dedup
charley-oai d58204f
Always skip reinjection during auto-compaction
charley-oai d33a1be
Simplify
charley-oai 714e0b7
Align compaction tests with always-skip post-layout
charley-oai a46bcf3
Inline compacted history shaping call
charley-oai 25c22dc
Unify model-switch persistence through compaction history
charley-oai 3759aba
Inline compact merge item matcher
charley-oai 2ede42d
Reinsert initial context for mid-turn compaction
charley-oai 223eda1
Reinject previous-turn context for pre-sampling model-switch compaction
charley-oai 454fa82
Use shared real-user matcher for initial-context insertion
charley-oai 7ed3d3f
Put NotNeeded first in pre-turn compaction outcome match
charley-oai c6d6312
Rename compaction callsite enum and exhaustively match reinjection
charley-oai 4c0ca09
Rename compact callsite vars and document reinjection policy
charley-oai 0fbc4c7
Clarify compaction reinjection rationale comments
charley-oai 96b88ae
Reinject context for summary-only mid-turn compaction
charley-oai 5ae08bc
Update compaction test for canonical context reinjection
charley-oai 7476184
Document user-anchor behavior for context reinjection
charley-oai b66c6e6
Reuse summary-user helper in compaction anchoring
charley-oai 16285c1
Move pre-turn context persistence to run_turn callsite
charley-oai 0c53637
nit
charley-oai 7b4e4b5
Remove redundant developer-role check in compaction filter
charley-oai 6901781
Fix clippy doc list formatting for anchor helper
charley-oai ca84df3
edge case
charley-oai c085499
Avoid dropping historical duplicates in remote echo stripping
charley-oai 8e6b114
Rename /compact start test for no-history semantics
charley-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does test need renaming?