Skip to content

Always expose view_image and return unsupported image-input error#11336

Merged
aibrahim-oai merged 7 commits intomainfrom
keep-view-image-tool-with-unsupported-error
Feb 10, 2026
Merged

Always expose view_image and return unsupported image-input error#11336
aibrahim-oai merged 7 commits intomainfrom
keep-view-image-tool-with-unsupported-error

Conversation

@aibrahim-oai
Copy link
Collaborator

  • Keep view_image in the advertised tool list for all models.
  • Return a clear error when the current model does not support image inputs, and cover it with a unit test.

@aibrahim-oai
Copy link
Collaborator Author

@codex fix this

@chatgpt-codex-connector
Copy link
Contributor

Summary

Testing

  • curl -I https://www.rust-lang.org
  • cd codex-rs && just fmt
  • cd codex-rs && cargo test -p codex-core test_build_specs_gpt5_codex_default
  • ⚠️ cd codex-rs && cargo test -p codex-core view_image_tool_returns_unsupported_message_for_text_only_model -- --nocapture (fails in this environment because codex-linux-sandbox binary is not discoverable by the test harness).

View task →

@aibrahim-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai aibrahim-oai merged commit 6e96e48 into main Feb 10, 2026
32 checks passed
@aibrahim-oai aibrahim-oai deleted the keep-view-image-tool-with-unsupported-error branch February 10, 2026 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments