Skip to content

rust-release: exclude cargo-timing.html from release assets#11564

Merged
bolinfest merged 1 commit intomainfrom
pr11564
Feb 12, 2026
Merged

rust-release: exclude cargo-timing.html from release assets#11564
bolinfest merged 1 commit intomainfrom
pr11564

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Feb 12, 2026

Why

The release job in .github/workflows/rust-release.yml uploads files: dist/** via softprops/action-gh-release. The downloaded timing artifacts include multiple files with the same basename, cargo-timing.html (one per target), which causes release asset collisions/races and can fail with GitHub release-assets API 404 Not Found errors.

What Changed

  • Updated the existing cleanup step before Create GitHub Release to remove all cargo-timing.html files from dist/.
  • Removed any now-empty directories after deleting those timing files.

Relevant change:

Verification

  • Confirmed from failing release logs that multiple cargo-timing.html files were being included in dist/** and that the release step failed while operating on duplicate-named assets.
  • Verified the workflow now deletes those files before the release upload step, so cargo-timing.html is no longer part of the release asset set.

@bolinfest bolinfest requested a review from pakrym-oai February 12, 2026 08:55
@bolinfest bolinfest changed the title ci: exclude cargo-timing.html from GitHub release assets rust-release: exclude cargo-timing.html from release assets Feb 12, 2026
@bolinfest bolinfest merged commit 26d9bdd into main Feb 12, 2026
32 checks passed
@bolinfest bolinfest deleted the pr11564 branch February 12, 2026 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments