Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
releasejob in.github/workflows/rust-release.ymluploadsfiles: dist/**viasoftprops/action-gh-release. The downloaded timing artifacts include multiple files with the same basename,cargo-timing.html(one per target), which causes release asset collisions/races and can fail with GitHub release-assets API404 Not Founderrors.What Changed
Create GitHub Releaseto remove allcargo-timing.htmlfiles fromdist/.Relevant change:
codex/.github/workflows/rust-release.yml
Line 423 in daba003
Verification
cargo-timing.htmlfiles were being included indist/**and that the release step failed while operating on duplicate-named assets.cargo-timing.htmlis no longer part of the release asset set.