[codex] Add preliminary MCP elicitations support as experimental feature#12192
Draft
canvrno-oai wants to merge 4 commits intomainfrom
Draft
[codex] Add preliminary MCP elicitations support as experimental feature#12192canvrno-oai wants to merge 4 commits intomainfrom
canvrno-oai wants to merge 4 commits intomainfrom
Conversation
canvrno-oai
force-pushed
the
canvrno/mcp_elicitations_prod
branch
3 times, most recently
from
187a4ac to
afcee74
Compare
| js_repl, | ||
| next_internal_sub_id: AtomicU64::new(0), | ||
| }); | ||
| sess.start_mcp_event_forwarder(rx_mcp_event); |
Collaborator
There was a problem hiding this comment.
Why do we need this?
Contributor
Author
There was a problem hiding this comment.
This takes events and forwards them into the session’s normal event stream, and intercepts codex_apps elicitation requests so codex can handle them via request_user_input. If you have a suggestion for an alternate approach (one that avoids this) I would be interested in following the approach you reccomend.
canvrno-oai
force-pushed
the
canvrno/mcp_elicitations_prod
branch
from
dba9119 to
d90dbed
Compare
canvrno-oai
force-pushed
the
canvrno/mcp_elicitations_prod
branch
3 times, most recently
from
9bb6d4f to
57c12b5
Compare
canvrno-oai
force-pushed
the
canvrno/mcp_elicitations_prod
branch
from
784f5b9 to
a763aff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.