feat: update Docker image digest to reflect #12205#12372
Merged
Conversation
This was referenced Feb 20, 2026
d99067a to
930fdc1
Compare
930fdc1 to
fda0467
Compare
fda0467 to
f411812
Compare
f411812 to
88b22ca
Compare
88b22ca to
8c42e64
Compare
8c42e64 to
f339171
Compare
f339171 to
7415443
Compare
7415443 to
6ee50f1
Compare
6ee50f1 to
8dbe204
Compare
8dbe204 to
74df7c9
Compare
74df7c9 to
8514e42
Compare
8514e42 to
059759b
Compare
059759b to
48a66cf
Compare
48a66cf to
865e064
Compare
865e064 to
6e2fca6
Compare
fjord-oai
added a commit
that referenced
this pull request
Feb 25, 2026
## Summary Stabilize `js_repl` runtime test setup in CI and move tool-facing `js_repl` behavior coverage into integration tests. This is a test/CI change only. No production `js_repl` behavior change is intended. ## Why - Bazel test sandboxes (especially on macOS) could resolve a different `node` than the one installed by `actions/setup-node`, which caused `js_repl` runtime/version failures. - `js_repl` runtime tests depend on platform-specific sandbox/test-harness behavior, so they need explicit gating in a base-stability commit. - Several tests in the `js_repl` unit test module were actually black-box/tool-level behavior tests and fit better in the integration suite. ## Changes - Add `actions/setup-node` to the Bazel and Rust `Tests` workflows, using the exact version pinned in the repo’s Node version file. - In Bazel (non-Windows), pass `CODEX_JS_REPL_NODE_PATH=$(which node)` into test env so `js_repl` uses the `actions/setup-node` runtime inside Bazel tests. - Add a new integration test suite for `js_repl` tool behavior and register it in the core integration test suite module. - Move black-box `js_repl` behavior tests into the integration suite (persistence/TLA, builtin tool invocation, recursive self-call rejection, `process` isolation, blocked builtin imports). - Keep white-box manager/kernel tests in the `js_repl` unit test module. - Gate `js_repl` runtime tests to run only on macOS and only when a usable Node runtime is available (skip on other platforms / missing Node in this commit). ## Impact - Reduces `js_repl` CI failures caused by Node resolution drift in Bazel. - Improves test organization by separating tool-facing behavior tests from white-box manager/kernel tests. - Keeps the base commit stable while expanding `js_repl` runtime coverage. #### [git stack](https://github.com/magus/git-stack-cli) - ✅ `1` #12372 - 👉 `2` #12407 - ⏳ `3` #12185 - ⏳ `4` #10673
git-stack-id: fjord/js_repl_seq---4htiuce17czvot git-stack-title: feat: update Docker image digest to reflect #12205
6e2fca6 to
fbfd6a5
Compare
bolinfest
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clone of #12371 for easier rebasing/testing.
git stack
1tests(js_repl): stabilize CI runtime test execution #124072feat: update Docker image digest to reflect #12205 #123723tests(js_repl): remove node-related skip paths from js_repl tests #121854Add feature-gated js_repl polling flow #10673