Skip to content

Comments

feat: update Docker image digest to reflect #12205#12372

Merged
fjord-oai merged 1 commit intomainfrom
fjord/js_repl_seq---4htiuce17czvot
Feb 25, 2026
Merged

feat: update Docker image digest to reflect #12205#12372
fjord-oai merged 1 commit intomainfrom
fjord/js_repl_seq---4htiuce17czvot

Conversation

@fjord-oai
Copy link
Contributor

@fjord-oai fjord-oai commented Feb 20, 2026

@etraut-openai etraut-openai added the oai PRs contributed by OpenAI employees label Feb 20, 2026
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from d99067a to 930fdc1 Compare February 21, 2026 01:11
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 01:11
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 03:31
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 930fdc1 to fda0467 Compare February 21, 2026 03:31
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 03:31
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 04:29
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from fda0467 to f411812 Compare February 21, 2026 04:29
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 04:29
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 07:49
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from f411812 to 88b22ca Compare February 21, 2026 07:49
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 07:49
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 08:05
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 88b22ca to 8c42e64 Compare February 21, 2026 08:05
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 08:05
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 16:19
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 8c42e64 to f339171 Compare February 21, 2026 16:19
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 16:19
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 17:01
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from f339171 to 7415443 Compare February 21, 2026 17:01
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 17:01
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 21, 2026 23:22
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 7415443 to 6ee50f1 Compare February 21, 2026 23:22
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 21, 2026 23:22
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 22, 2026 00:12
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 6ee50f1 to 8dbe204 Compare February 22, 2026 00:12
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 22, 2026 00:12
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 22, 2026 22:07
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 8dbe204 to 74df7c9 Compare February 22, 2026 22:07
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 22, 2026 22:07
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 22, 2026 22:21
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 74df7c9 to 8514e42 Compare February 22, 2026 22:21
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 22, 2026 22:21
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 25, 2026 02:31
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 8514e42 to 059759b Compare February 25, 2026 02:31
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 25, 2026 02:31
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 25, 2026 03:01
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 059759b to 48a66cf Compare February 25, 2026 03:01
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 25, 2026 03:01
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 25, 2026 03:10
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 48a66cf to 865e064 Compare February 25, 2026 03:10
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 25, 2026 03:10
@fjord-oai fjord-oai changed the base branch from fjord/js_repl_seq---4htl2cund94dlu to main February 25, 2026 03:59
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 865e064 to 6e2fca6 Compare February 25, 2026 03:59
@fjord-oai fjord-oai changed the base branch from main to fjord/js_repl_seq---4htl2cund94dlu February 25, 2026 03:59
fjord-oai added a commit that referenced this pull request Feb 25, 2026
## Summary

Stabilize `js_repl` runtime test setup in CI and move tool-facing
`js_repl` behavior coverage into integration tests.

This is a test/CI change only. No production `js_repl` behavior change
is intended.

## Why

- Bazel test sandboxes (especially on macOS) could resolve a different
`node` than the one installed by `actions/setup-node`, which caused
`js_repl` runtime/version failures.
- `js_repl` runtime tests depend on platform-specific
sandbox/test-harness behavior, so they need explicit gating in a
base-stability commit.
- Several tests in the `js_repl` unit test module were actually
black-box/tool-level behavior tests and fit better in the integration
suite.

## Changes

- Add `actions/setup-node` to the Bazel and Rust `Tests` workflows,
using the exact version pinned in the repo’s Node version file.
- In Bazel (non-Windows), pass `CODEX_JS_REPL_NODE_PATH=$(which node)`
into test env so `js_repl` uses the `actions/setup-node` runtime inside
Bazel tests.
- Add a new integration test suite for `js_repl` tool behavior and
register it in the core integration test suite module.
- Move black-box `js_repl` behavior tests into the integration suite
(persistence/TLA, builtin tool invocation, recursive self-call
rejection, `process` isolation, blocked builtin imports).
- Keep white-box manager/kernel tests in the `js_repl` unit test module.
- Gate `js_repl` runtime tests to run only on macOS and only when a
usable Node runtime is available (skip on other platforms / missing Node
in this commit).

## Impact

- Reduces `js_repl` CI failures caused by Node resolution drift in
Bazel.
- Improves test organization by separating tool-facing behavior tests
from white-box manager/kernel tests.
- Keeps the base commit stable while expanding `js_repl` runtime
coverage.


#### [git stack](https://github.com/magus/git-stack-cli)
- ✅ `1` #12372
- 👉 `2` #12407
- ⏳ `3` #12185
- ⏳ `4` #10673
Base automatically changed from fjord/js_repl_seq---4htl2cund94dlu to main February 25, 2026 05:04
git-stack-id: fjord/js_repl_seq---4htiuce17czvot
git-stack-title: feat: update Docker image digest to reflect #12205
@fjord-oai fjord-oai force-pushed the fjord/js_repl_seq---4htiuce17czvot branch from 6e2fca6 to fbfd6a5 Compare February 25, 2026 05:06
@fjord-oai fjord-oai marked this pull request as ready for review February 25, 2026 05:55
@fjord-oai fjord-oai merged commit 6cb2f02 into main Feb 25, 2026
32 of 40 checks passed
@fjord-oai fjord-oai deleted the fjord/js_repl_seq---4htiuce17czvot branch February 25, 2026 06:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants