feat(tui) - /copy by won-openai · Pull Request #12613 · openai/codex

won-openai · 2026-02-23T19:32:18Z

/copy!

/copy allows you to copy the latest complete message from Codex on the TUI.

chatgpt-codex-connector

💡 Codex Review

Lines 1226 to 1231 in 9531d92

    
           fn on_agent_message(&mut self, message: String) { 
        
               // If we have a stream_controller, then the final agent message is redundant and will be a 
        
               // duplicate of what has already been streamed. 
        
               if self.stream_controller.is_none() && !message.is_empty() { 
        
                   self.handle_streaming_delta(message); 
        
               }

Store legacy AgentMessage text before enabling /copy

on_agent_message displays completed assistant text but does not update last_copyable_output. In event flows that still emit EventMsg::AgentMessage (without item-completed capture), /copy cannot copy the latest visible reply and instead falls back to older content or reports nothing.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

…entaries

won-openai · 2026-02-23T19:49:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 4286 to 4291 in c0ea947

    
           EventMsg::ThreadRolledBack(rollback) => { 
        
               if from_replay { 
        
                   self.app_event_tx.send(AppEvent::ApplyThreadRollback { 
        
                       num_turns: rollback.num_turns, 
        
                   }); 
        
               }

Clear copied-output cache when turns are rolled back

/copy uses self.last_copyable_output, but ThreadRolledBack only triggers transcript trimming and never updates that cache. After undo/backtrack removes the most recent assistant turn, /copy can still copy the removed reply, so it no longer reflects the latest visible Codex output.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-23T19:56:45Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

won-openai · 2026-02-23T22:57:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a102f22a07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

chatgpt-codex-connector · 2026-02-23T23:04:51Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

aibrahim-oai · 2026-02-24T00:26:16Z

codex-rs/tui/src/chatwidget.rs

    status_line_branch_lookup_complete: bool,
    external_editor_state: ExternalEditorState,
+    #[cfg(test)]
+    clipboard_text_writer_override: Option<ClipboardTextWriterOverride>,


let's not have a state purely for tests. we can simulate it.

aibrahim-oai · 2026-02-24T00:26:47Z

codex-rs/tui/src/chatwidget.rs

+            Some(MessagePhase::FinalAnswer) | None => true,
+            Some(MessagePhase::Commentary) => false,
+        };
+        if should_capture_copyable_output && !message.trim().is_empty() {


you don't need this change if you are doing it at task complete also.

aibrahim-oai · 2026-02-24T00:27:05Z

codex-rs/tui/src/chatwidget.rs

    /// phase for legacy models) clears the flag to preserve historical behavior.
    fn on_agent_message_item_completed(&mut self, item: AgentMessageItem) {
+        let should_capture_copyable_output = match item.phase.as_ref() {
+            Some(MessagePhase::FinalAnswer) | None => true,


same as above. task complete is enough

aibrahim-oai · 2026-02-24T00:27:12Z

codex-rs/tui/src/chatwidget.rs

            Some(MessagePhase::FinalAnswer) | None => false,
            Some(MessagePhase::Commentary) => true,
        };
+        if should_capture_copyable_output {


aibrahim-oai · 2026-02-24T00:27:31Z

codex-rs/tui/src/chatwidget.rs

+                };
+
+                #[cfg(test)]
+                let copy_result = if let Some(writer) = &self.clipboard_text_writer_override {


let's not have test logic like that in the code

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c6fd82111

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

/copy feature

9531d92

chatgpt-codex-connector bot reviewed Feb 23, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

added barrier to copy cache only for final/no-phase messages, no comm…

c0ea947

…entaries

chatgpt-codex-connector bot reviewed Feb 23, 2026

View reviewed changes

etraut-openai added the oai PRs contributed by OpenAI employees label Feb 23, 2026

won-openai added 2 commits February 23, 2026 14:18

rollback cache reset

09f68b4

test case code redundant clone issue

a102f22

chatgpt-codex-connector bot reviewed Feb 23, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

aibrahim-oai reviewed Feb 24, 2026

View reviewed changes

simplified logic

1c6fd82

chatgpt-codex-connector bot reviewed Feb 24, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

won-openai added 2 commits February 23, 2026 19:00

codex srsly?

c90bbfc

removed unnecessary logic

5d49114

github-actions bot mentioned this pull request Feb 24, 2026

📊 AI CLI 工具社区动态日报 2026-02-24 duanyytop/agents-radar#7

Open

	fn on_agent_message(&mut self, message: String) {
	// If we have a stream_controller, then the final agent message is redundant and will be a
	// duplicate of what has already been streamed.
	if self.stream_controller.is_none() && !message.is_empty() {
	self.handle_streaming_delta(message);
	}

	EventMsg::ThreadRolledBack(rollback) => {
	if from_replay {
	self.app_event_tx.send(AppEvent::ApplyThreadRollback {
	num_turns: rollback.num_turns,
	});
	}

Comments

Conversation

won-openai commented Feb 23, 2026

/copy!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

won-openai commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot commented Feb 23, 2026

Uh oh!

won-openai commented Feb 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Feb 23, 2026

Uh oh!

aibrahim-oai Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants