Handle realtime spawn_transcript delegation#12619
Conversation
- delegate incoming realtime items using \n- add core integration coverage to keep delegation non-blocking for realtime audio\n\nCo-authored-by: Codex <noreply@openai.com>
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c3a091186
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…://github.com/openai/codex into aibrahim/realtime-spawn-transcript-delegation
|
@codex review |
|
Security review completed. No security issues were found in this pull request. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5387c1b08b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Some("spawn_transcript") => item | ||
| .get("delta_user_transcript") | ||
| .and_then(Value::as_str) | ||
| .and_then(|text| (!text.is_empty()).then(|| text.to_string())), |
There was a problem hiding this comment.
realtime_text_from_conversation_item forwards delta_user_transcript as the user turn text. In spawn_transcript events this value is incremental, so delegation can send only the newest fragment (or multiple fragmented turns as deltas arrive), losing earlier words. Delegate from full_user_transcript/backend_prompt_messages instead (and dedupe by seq if needed).
Useful? React with 👍 / 👎.
aibrahim-oai
deleted the
aibrahim/realtime-spawn-transcript-delegation
branch
2 participants
No description provided.