Always send entire request context #1641
Conversation
| | ResponseItem::FunctionCallOutput { .. } => filtered.push(item.clone()), | ||
| ResponseItem::Reasoning { .. } | ResponseItem::Other => { | ||
| | ResponseItem::FunctionCallOutput { .. } | ||
| | ResponseItem::Reasoning { .. } => filtered.push(item.clone()), |
There was a problem hiding this comment.
We need to persist reasoning items to send them along later otherwise requests will fail
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for FunctionCallOutputPayload { |
There was a problem hiding this comment.
Fix deserialization of FunctionCallOutputs from rollouts
There was a problem hiding this comment.
Maybe include this as a comment with a bit more specificity? I don't know what "fix" means without more context.
There was a problem hiding this comment.
The comment is above the serialize method. This just adds the deserialize for parity.
gpeal
left a comment
gpeal
left a comment
There was a problem hiding this comment.
This looks great! I'll let Michael make the final call on this one though.
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for FunctionCallOutputPayload { |
There was a problem hiding this comment.
Maybe include this as a comment with a bit more specificity? I don't know what "fix" means without more context.
# Conflicts: # codex-rs/core/src/codex.rs # codex-rs/core/tests/previous_response_id.rs
Always store the entire conversation history.
Request encrypted COT when not storing Responses.
Send entire input context instead of sending previous_response_id