Skip to content

Conversation

@david-strejc
Copy link

Summary

  • convert MCP tool image blocks into data URIs and queue them as upcoming InputItem::Image
  • keep accompanying text blocks from the tool result so they are replayed to the model alongside the image
  • warn if queuing fails, ensuring we still answer the tool call

Testing

  • cargo test -p codex-core
  • cargo test --all-features

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@david-strejc
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@david-strejc
Copy link
Author

Rechecked after signing the CLA.

@david-strejc
Copy link
Author

recheck

1 similar comment
@david-strejc
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Sep 20, 2025
@etraut-openai
Copy link
Collaborator

Thanks for the contribution, and apologies for the slow response. We've received many PRs, and we don't have the bandwidth on the codex team to review all of them.

It appears that this PR is no longer needed. Support for MCP tool images was recently added, so this should work in the latest version of codex. Let us know if you run into any problems with it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
@openai openai unlocked this conversation Oct 30, 2025
youta7 added a commit to youta7/ta-codex that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants