Skip to content

Conversation

@SaaiAravindhRaja
Copy link

External (non-OpenAI) Pull Request Requirements

This pull request adds two new helper functions to the codex-rs/common/src/fuzzy_match.rs module, making it easier to check for fuzzy matches and retrieve match scores. It also introduces corresponding unit tests to ensure these helpers work correctly.

Fuzzy matching helpers:

  • Added fuzzy_matches, a convenience function that returns true if needle fuzzy-matches haystack (codex-rs/common/src/fuzzy_match.rs)
  • Added fuzzy_score, a function that returns the fuzzy match score if a match exists, or None otherwise (codex-rs/common/src/fuzzy_match.rs)

Testing:

  • Added unit tests for the new fuzzy_matches and fuzzy_score helper functions to validate their behavior (codex-rs/common/src/fuzzy_match.rs)

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@SaaiAravindhRaja
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 20, 2025
@bolinfest
Copy link
Collaborator

I feel like this is trivial for anyone to add this helper functions who is using this externally. Since we aren't using it ourselves in the Codex CLI codebase and we are not publishing these crates for external use, I am not going to take this change. It would like get deleted as unused code at some point on our side, anyway.

@bolinfest bolinfest closed this Sep 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants