fix: Update seatbelt policy for java on macOS #3987
Merged
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
| env.remove("JAVA_HOME"); | ||
| env.remove(CODEX_SANDBOX_ENV_VAR); | ||
|
|
||
| let mut child = spawn_command_under_seatbelt( |
Collaborator
There was a problem hiding this comment.
I think cargo clippy is asking you to drop the mut here
Suggested change
| let mut child = spawn_command_under_seatbelt( | |
| let child = spawn_command_under_seatbelt( |
Collaborator
|
Overall looks good, just a minor lint issue. |
Contributor
Author
|
I pushed a fix for the test. Please confirm you want to keep the test, btw. |
|
Looking for this to make it in soon! Nearly all of my codex responses contain: |
aibrahim-oai
approved these changes
Oct 30, 2025
Collaborator
aibrahim-oai
left a comment
aibrahim-oai
left a comment
There was a problem hiding this comment.
Approving after syncing with @nornagon-openai
Collaborator
|
@bn3t, thanks for the contribution. I think this will make a lot of Codex users happy! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to the Issue #3978 and contains a fix to the seatbelt profile for macOS that allows to run java/jdk tooling from the sandbox. I have found that the included change is the minimum change to make it run on my machine.
There is a unit test added by codex when making this fix. I wonder if it is useful since you need java installed on the target machine for it to be relevant. I can remove it it is better.
Fixes #3978