adding system date to env context #5993
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let system_date = Local::now().format("%Y-%m-%d").to_string(); | ||
| format!( |
There was a problem hiding this comment.
default_env_context_str now calls Local::now() each time we build the expected XML. The helper is invoked after the HTTP requests have already been recorded, so if a test happens to straddle midnight the real request body will still contain the previous date while this helper formats the new date. That causes the prompt-caching tests to fail nondeterministically once per day. Please capture the system date once (e.g. at test setup time and thread it through) or read it from the recorded request instead of calling Local::now() during the assertion.
Useful? React with 👍 / 👎.
No description provided.