Allow global exec flags after resume and fix CI codex build/timeout
#8440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
fjord-oai
force-pushed
the
codex/check-image-support-for-codex-exec-resume
branch
from
98640de to
6de6bfb
Compare
fjord-oai
changed the title
codex exec resume (add --image to resume)resume and fix CI codex build/timeout
fjord-oai
force-pushed
the
codex/check-image-support-for-codex-exec-resume
branch
from
5bda9b2 to
722b4a3
Compare
dylan-hurd-oai
approved these changes
Jan 5, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
codex exec resumeto parity with top‑level flags so global options (git check bypass, json, model, sandbox toggles) work after the subcommand, including when outside a git repo.Description
--skip-git-repo-check,--json,--model,--full-auto, and--dangerously-bypass-approvals-and-sandboxas global so they’re accepted afterresume.exec_resume_accepts_global_flags_after_subcommandto verify those flags work when passed afterresume.Testing
just fmtcargo test -p codex-exec(pass; ran with elevated perms to allow network/port binds)codex exec resumewith global flags after the subcommand to confirm behavior.