Skip to content

Conversation

@tibo-openai
Copy link
Collaborator

@tibo-openai tibo-openai commented Jan 7, 2026

Fixes apply.rs path parsing so quoted diff headers are tokenized and C-style escapes are decoded, /dev/null headers are ignored before prefix stripping to avoid bogus dev/null paths, and git apply output paths are unescaped from C-style quoting; this prevents missed staging and misclassified paths when applying or reverting patches, improving reliability for repos with spaces or escaped characters in filenames. Tested with just fix -p codex-git and cargo test -p codex-git.

@tibo-openai tibo-openai marked this pull request as ready for review January 7, 2026 12:37
@tibo-openai tibo-openai enabled auto-merge (squash) January 7, 2026 12:38
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2057d502c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tibo-openai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4b8330b5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tibo-openai tibo-openai merged commit a590523 into main Jan 7, 2026
26 checks passed
@tibo-openai tibo-openai deleted the tibo/git-apply-path-parse branch January 7, 2026 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants