fix: remove existing process hardening from Codex CLI #8951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this. I submitted a PR last November but was told to go through issues first as a potential feature and not a bug. Pull Request Draft. My theory is that this is the ghost @tibo-openai was looking for last October. #8945 (comment) |
viyatb-oai
approved these changes
Jan 9, 2026
Collaborator
Author
|
@johnzfitch FYI, I cut an alpha release with this fix if you're willing to try it out and verify it fixes the issues you've reported: https://github.com/openai/codex/releases/tag/rust-v0.80.0-alpha.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #8945 and #8472, there are legitimate cases where users expect processes spawned by Codex to inherit environment variables such as
LD_LIBRARY_PATHandDYLD_LIBRARY_PATH, where failing to do so can cause significant performance issues.This PR removes the use of
codex_process_hardening::pre_main_hardening()in Codex CLI (which was added not in response to a known security issue, but because it seemed like a prudent thing to do from a security perspective: #4521), but we will continue to use it incodex-responses-api-proxy. At some point, we probably want to introduce a slightly different version ofcodex_process_hardening::pre_main_hardening()in Codex CLI that excludes said environment variables from the Codex process itself, but continues to propagate them to subprocesses.