feat: collab wait multiple IDs #9294
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37d24c5398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let receiver_thread_ids = end_event.statuses.keys().map(ToString::to_string).collect(); | ||
| let agents_states = end_event |
There was a problem hiding this comment.
Here receiver_thread_ids is derived only from end_event.statuses keys, but the wait handler sends an empty statuses map when no agent reaches a final state before timeout. In that case the completed item will show an empty receiver list even though the call targeted specific agents, and clients treating item/completed as authoritative lose the ability to display which agents were waited on. Consider carrying the original receiver_thread_ids through the end event (or merging with the started item) so timeouts and partial completions still include the full target list.
Useful? React with 👍 / 👎.
No description provided.