Only load config from trusted folders #9533
Merged
+207
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gt-oai
force-pushed
the
gt/only-load-trusted-config
branch
from
9a05169 to
b69256b
Compare
jif-oai
approved these changes
Jan 20, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
We should add this to the doc website as well
| let project_root = find_project_root(&cwd, &project_root_markers).await?; | ||
| let project_layers = load_project_layers(&cwd, &project_root).await?; | ||
| layers.extend(project_layers); | ||
| if let Some(project_root) = |
Collaborator
There was a problem hiding this comment.
We should send a warning to the user instead of silently ignoring
Contributor
Author
There was a problem hiding this comment.
Good point, will print a warning iff you have CWD / git repo codex config AND the folder is untrusted (will do in a follow up)
Collaborator
|
FYI this PR has some side effect for skill discovery. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config includes multiple code execution entrypoints.
Now, we load the config from predetermined locations first (~/.codex/config.toml etc), use those to learn which folders are 'trusted', and only load additional config from the CWD if it is trusted.