error code/msg details for failed elevated setup #9941
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52c403c3ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
2 follow-ups I think we need to address but in favor of better reporting!
| } | ||
| if let Some(message) = message_tag.as_deref() { | ||
| tags.push(("message", message)); | ||
| } |
There was a problem hiding this comment.
non-blocking but would be great to include in core
There was a problem hiding this comment.
yes - one of the things we'll address when we implement the NUX in the vsce is moving all the metrics stuff to core, so it gets included
| .with_context(|| format!("create sandbox dir {}", sandbox_dir.display()))?; | ||
| let path = setup_error_path(codex_home); | ||
| let json = serde_json::to_vec_pretty(report)?; | ||
| fs::write(&path, json).with_context(|| format!("write {}", path.display()))?; |
There was a problem hiding this comment.
Do we intend for this to be an append-only log, or only contain the most recent run? I think we want to make this more resilient to race conditions here.
There was a problem hiding this comment.
it gets deleted before the setup process runs - right now there really should just be one concurrent setup running, but I'll look into handling concurrency just in case
No description provided.