-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show evals in wandb weave #1522
Draft
yogeshg
wants to merge
7
commits into
openai:main
Choose a base branch
from
yogeshg:yo-springcleaning-show-json-circ-dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` <module 'evals.cli.oaieval' from '/Users/yo/code/oai-evals-2/evals/cli/oaieval.py'> [2024-04-19 14:16:44,914] [registry.py:271] Loading registry from /Users/yo/code/oai-evals-2/evals/registry/evals [2024-04-19 14:16:45,255] [registry.py:271] Loading registry from /Users/yo/.evals/evals [2024-04-19 14:16:45,256] [oaieval.py:215] Run started: 240419211645BXWDMDYQ using spec, found a class. eval_class=functools.partial(<class 'evals.elsuite.basic.match_with_solvers.MatchWithSolvers'>, samples_jsonl='theory_of_mind/tomi/test.jsonl', task_description='You will read a number of sentences describing a situation involving several people, as well as a question regarding the real or perceived location of an object. Your task is to answer the question based on the information in the sentences. Respond with the single word corresponding to the location.') eval_spec=EvalSpec(cls='evals.elsuite.basic.match_with_solvers:MatchWithSolvers', registry_path=PosixPath('/Users/yo/code/oai-evals-2/evals/registry'), args={'samples_jsonl': 'theory_of_mind/tomi/test.jsonl', 'task_description': 'You will read a number of sentences describing a situation involving several people, as well as a question regarding the real or perceived location of an object. Your task is to answer the question based on the information in the sentences. Respond with the single word corresponding to the location.'}, key='theory_of_mind.tomi', group='theory_of_mind') Running eval theory_of_mind.tomi [2024-04-19 14:16:45,262] [oaieval.py:276] Found 0/0 sampling events with usage data Traceback (most recent call last): File "/opt/homebrew/bin/oaieval", line 10, in <module> sys.exit(main()) File "/Users/yo/code/oai-evals-2/evals/cli/oaieval.py", line 305, in main run(args) File "/Users/yo/code/oai-evals-2/evals/cli/oaieval.py", line 229, in run recorder.record_final_report(result) File "/Users/yo/code/oai-evals-2/evals/record.py", line 369, in record_final_report f.write((jsondumps({"final_report": final_report, "run_id": self.run_spec.run_id}) + "\n").encode("utf-8")) File "/Users/yo/code/oai-evals-2/evals/data.py", line 218, in jsondumps return json.dumps(o, cls=EnhancedJSONEncoder, ensure_ascii=ensure_ascii, **kwargs) File "/opt/homebrew/Cellar/python@3.10/3.10.12_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/__init__.py", line 238, in dumps **kw).encode(obj) File "/opt/homebrew/Cellar/python@3.10/3.10.12_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/encoder.py", line 199, in encode chunks = self.iterencode(o, _one_shot=True) File "/opt/homebrew/Cellar/python@3.10/3.10.12_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/encoder.py", line 257, in iterencode return _iterencode(o, 0) ValueError: Circular reference detected ```
yogeshg
commented
Apr 19, 2024
yogeshg
commented
Apr 19, 2024
yogeshg
commented
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing an eval!♥️
🚨 Please make sure your PR follows these guidelines, failure to follow the guidelines below will result in the PR being closed automatically. Note that even if the criteria are met, that does not guarantee the PR will be merged nor GPT-4 access be granted. 🚨
PLEASE READ THIS:
In order for a PR to be merged, it must fail on GPT-4. We are aware that right now, users do not have access, so you will not be able to tell if the eval fails or not. Please run your eval with GPT-3.5-Turbo, but keep in mind as we run the eval, if GPT-4 gets higher than 90% on the eval, we will likely reject it since GPT-4 is already capable of completing the task.
We plan to roll out a way for users submitting evals to see the eval performance on GPT-4 soon. Stay tuned! Until then, you will not be able to see the eval performance on GPT-4. Starting April 10, the minimum eval count is 15 samples, we hope this makes it easier to create and contribute evals.
Also, please note that we're using Git LFS for storing the JSON files, so please make sure that you move the JSON file to Git LFS before submitting a PR. Details on how to use Git LFS are available here.
Eval details 📑
Eval name
[Insert Eval name here]
Eval description
[Insert a short description of what your eval does here]
What makes this a useful eval?
[Insert why this eval is worth including and any additional context]
Criteria for a good eval ✅
Below are some of the criteria we look for in a good eval. In general, we are seeking cases where the model does not do a good job despite being capable of generating a good response (note that there are some things large language models cannot do, so those would not make good evals).
Your eval should be:
Basic
evals or theFact
Model-graded eval, or an exhaustive rubric for evaluating answers for theCriteria
Model-graded eval.If there is anything else that makes your eval worth including, please document it below.
Unique eval value
Eval structure 🏗️
Your eval should
evals/registry/data/{name}
evals/registry/evals/{name}.yaml
(For now, we will only be approving evals that use one of the existing eval classes. You may still write custom eval classes for your own cases, and we may consider merging them in the future.)
Final checklist 👀
Submission agreement
By contributing to Evals, you are agreeing to make your evaluation logic and data under the same MIT license as this repository. You must have adequate rights to upload any data used in an Eval. OpenAI reserves the right to use this data in future service improvements to our product. Contributions to OpenAI Evals will be subject to our usual Usage Policies (https://platform.openai.com/docs/usage-policies).
Email address validation
If your submission is accepted, we will be granting GPT-4 access to a limited number of contributors. Access will be given to the email address associated with the commits on the merged pull request.
Limited availability acknowledgment
We know that you might be excited to contribute to OpenAI's mission, help improve our models, and gain access to GPT-4. However, due to the requirements mentioned above and the high volume of submissions, we will not be able to accept all submissions and thus not grant everyone who opens a PR GPT-4 access. We know this is disappointing, but we hope to set the right expectation before you open this PR.
Submit eval
pip install pre-commit; pre-commit install
and have verified thatmypy
,black
,isort
,autoflake
andruff
are running when I commit and pushFailure to fill out all required fields will result in the PR being closed.
Eval JSON data
Since we are using Git LFS, we are asking eval submitters to add in as many Eval Samples (at least 5) from their contribution here:
View evals in JSON
Eval
INSERT_EVAL_HERE