Skip to content

Add engine accessor to SQLAlchemySession for closing it when it's created from a URL #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

Add engine accessor to SQLAlchemySession for closing it when it's created from a URL #1960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74e1d74
feat: Add engine property accessor to SQLAlchemySession
gn00295120 Oct 21, 2025
1bdc14f
test: Add unit tests for engine property accessor
gn00295120 Oct 21, 2025
7a89b7c
Merge branch 'main' into fix/sqlalchemy-session-engine-disposal
gn00295120 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/agents/extensions/memory/sqlalchemy_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,3 +319,16 @@ async def clear_session(self) -> None:
await sess.execute(
delete(self._sessions).where(self._sessions.c.session_id == self.session_id)
)

@property
def engine(self) -> AsyncEngine:
"""Access the underlying SQLAlchemy AsyncEngine.

This property provides direct access to the engine for advanced use cases,
such as checking connection pool status, configuring engine settings,
or manually disposing the engine when needed.

Returns:
AsyncEngine: The SQLAlchemy async engine instance.
"""
return self._engine