Add session customization params #2196

danielquintas8 · 2025-12-16T22:35:41Z

feat: Add session_limit parameter to control conversation history retrieval from sessions and include new test.

…etrieval from sessions and include new test.

seratch

Thanks for sending this pull request! Adding the limit option is reasonable, but we'd like to make the new option to be open to future enhancement. So can you create new SessionSettings class (in the same way with ModelSettings) and move the liimt parameter as the first and only property in it?

…n, including default item retrieval limits.

…ed session management

…eval limits and add corresponding tests

…em retrieval limits and add corresponding tests

…al limits and add corresponding tests

…trieval limits and add corresponding tests

…its and add corresponding tests

…or item retrieval limits and add corresponding tests

…pose the conversation ID with lazy initialization check.

danielquintas8 · 2025-12-17T21:01:40Z

Thanks for sending this pull request! Adding the limit option is reasonable, but we'd like to make the new option to be open to future enhancement. So can you create new SessionSettings class (in the same way with ModelSettings) and move the limit parameter as the first and only property in it?

Thanks for the feedback! I've refactored the implementation, following the same pattern as ModelSettings.

Changes made:

Created SessionSettings dataclass with limit as the first property
Added session_settings parameter to all session constructors and from_url/ from_address method
Integrated SessionSettings into RunConfig for runtime overrides
Added resolve() method for merging settings (base + override)
Updated all 7 session implementations consistently

I believe this is extensible for future properties. For example, I'd like to add branch_id support for conversation branching in AdvancedSQLiteSession (and a potential AdvancedSQLAlchemySession). If you're open to it, I can also implement it since I need it for my use case anyway.

Let me know if it needs any adjustments

…nd SessionSettings objects.

src/agents/memory/session_settings.py

seratch · 2026-01-20T22:20:28Z

Can you also resolve the conflicts?

src/agents/memory/session_settings.py

seratch · 2026-01-22T22:28:07Z

I haven't checked what's wrong here, but the tests are still failing

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e590fcb5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/agents/run.py

danielquintas8 · 2026-01-23T00:03:23Z

I haven't checked what's wrong here, but the tests are still failing

I forget to make it into Draft as I was planning to validate everything afterwards. It should work now

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: decd19f31d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/agents/run.py

feat: Add session_limit parameter to control conversation history r…

80324cb

…etrieval from sessions and include new test.

danielquintas8 marked this pull request as draft December 16, 2025 22:38

refactor: linting

1f08ea4

danielquintas8 marked this pull request as ready for review December 16, 2025 22:45

seratch added enhancement New feature or request feature:core feature:sessions labels Dec 17, 2025

seratch added this to the 0.6.x milestone Dec 17, 2025

seratch requested changes Dec 17, 2025

View reviewed changes

seratch changed the title ~~Session limit parameter on Runner~~ Add session customization options to Runner options Dec 17, 2025

seratch changed the title ~~Add session customization options to Runner options~~ Add session customization params to Runner options Dec 17, 2025

seratch marked this pull request as draft December 17, 2025 08:23

danielquintas8 added 12 commits December 17, 2025 18:27

feat: Introduce SessionSettings to standardize session configuratio…

82054fa

…n, including default item retrieval limits.

feat: Integrate SessionSettings into Session and RunConfig for enhanc…

ed73dda

…ed session management

feat: Enhance SQLiteSession to utilize SessionSettings for item retri…

1571292

…eval limits and add corresponding tests

feat: Enhance AdvancedSQLiteSession to utilize SessionSettings for it…

142e86a

…em retrieval limits and add corresponding tests

feat: Enhance DaprSession to utilize SessionSettings for item retriev…

55f6172

…al limits and add corresponding tests

feat: Enhance EncryptedSession to utilize SessionSettings for item re…

53a8ae6

…trieval limits and add corresponding tests

feat: Enhance SQAlchemySession to utilize SessionSettings for item re…

1da6e62

…trieval limits and add corresponding tests

feat: Enhance Redis to utilize SessionSettings for item retrieval lim…

1216ab9

…its and add corresponding tests

feat: Enhance OpenAIConversationsSession to utilize SessionSettings f…

44bf3e3

…or item retrieval limits and add corresponding tests

test: add key_prefix to RedisSession.from_url initialization in tests.

46e9a39

feat: add session_settings parameter to AdvancedSQLiteSession

dd3a367

feat: Add session_id property to OpenAIConversationsSession to ex…

7475ddf

…pose the conversation ID with lazy initialization check.

danielquintas8 marked this pull request as ready for review December 17, 2025 20:47

danielquintas8 requested a review from seratch December 17, 2025 20:48

danielquintas8 added 3 commits December 17, 2025 21:07

refactor: Migrate session limit parameter in tests to use RunConfig a…

99a7226

…nd SessionSettings objects.

fix: mypy issues

c2c3090

fix: lint and format

6425a24

seratch reviewed Jan 8, 2026

View reviewed changes

src/agents/memory/session_settings.py Outdated Show resolved Hide resolved

refactor: replace SessionSettings.get_limit with resolve_session_limit

20b72da

danielquintas8 requested a review from seratch January 20, 2026 10:37

seratch requested changes Jan 20, 2026

View reviewed changes

src/agents/memory/session_settings.py Outdated Show resolved Hide resolved

src/agents/memory/session_settings.py Outdated Show resolved Hide resolved

seratch marked this pull request as draft January 20, 2026 22:19

seratch changed the title ~~Add session customization params to Runner options~~ Add session customization params Jan 20, 2026

seratch modified the milestones: 0.7.x, 0.8.x Jan 22, 2026

danielquintas8 and others added 2 commits January 22, 2026 20:56

refactor SessionSettings to_dict method

e26005b

Merge branch 'main' into session_limit

1e590fc

seratch marked this pull request as ready for review January 22, 2026 22:23

seratch modified the milestones: 0.8.x, 0.7.x Jan 22, 2026

seratch reviewed Jan 22, 2026

View reviewed changes

src/agents/memory/session_settings.py Outdated Show resolved Hide resolved

fix lint error

9bab137

seratch modified the milestones: 0.7.x, 0.8.x Jan 22, 2026

seratch marked this pull request as draft January 22, 2026 22:28

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

src/agents/run.py Outdated Show resolved Hide resolved

danielquintas8 and others added 2 commits January 23, 2026 00:01

removed callback check

a2369a2

Merge branch 'main' into session_limit

decd19f

danielquintas8 marked this pull request as ready for review January 23, 2026 00:02

danielquintas8 requested a review from seratch January 23, 2026 00:02

chatgpt-codex-connector bot reviewed Jan 23, 2026

View reviewed changes

src/agents/run.py Outdated Show resolved Hide resolved

seratch marked this pull request as draft January 23, 2026 00:13

fixed backward compatibility issue

77beb74

danielquintas8 marked this pull request as ready for review January 23, 2026 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add session customization params #2196

Add session customization params #2196

Uh oh!

danielquintas8 commented Dec 16, 2025

Uh oh!

seratch left a comment

Uh oh!

danielquintas8 commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seratch commented Jan 20, 2026

Uh oh!

Uh oh!

seratch commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

danielquintas8 commented Jan 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add session customization params #2196

Are you sure you want to change the base?

Add session customization params #2196

Uh oh!

Conversation

danielquintas8 commented Dec 16, 2025

Uh oh!

seratch left a comment

Choose a reason for hiding this comment

Uh oh!

danielquintas8 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seratch commented Jan 20, 2026

Uh oh!

Uh oh!

seratch commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

danielquintas8 commented Jan 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danielquintas8 commented Dec 17, 2025 •

edited

Loading