Make the reset behavior on tool use configurable #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenheidel
previously approved these changes
Mar 25, 2025
src/agents/_run_impl.py
Outdated
| @@ -77,6 +77,22 @@ class QueueCompleteSentinel: | |||
| _NOT_FINAL_OUTPUT = ToolsToFinalOutputResult(is_final_output=False, final_output=None) | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class AgentToolUseTracker: | |||
| data: list[tuple[Agent, list[str]]] = field(default_factory=list) | |||
There was a problem hiding this comment.
better name than data? i couldn't figure out what this is
| @@ -208,8 +208,10 @@ async def _fetch_response( | |||
| list_input = ItemHelpers.input_to_new_input_list(input) | |||
|
|
|||
| parallel_tool_calls = ( | |||
There was a problem hiding this comment.
this would be easier to read as an if/elif/else block rather than this expression
## Summary: #263 added this behavior. The goal was to prevent infinite loops when tool choice was set. The key change I'm making is: 1. Making it configurable on the agent. 2. Doing bookkeeping in the Runner to track this, to prevent mutating agents. 3. Not resetting the global tool choice in RunConfig. ## Test Plan: Unit tests. .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#263 added this behavior. The goal was to prevent infinite loops when tool choice was set. The key change I'm making is:
Test Plan:
Unit tests.
.