Add reasoning content - fix on #494 #871
Open
+511
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-openai
approved these changes
Jun 15, 2025
|
this looks great - can you please fix lint and i can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my personal update on #494
Key changes:
ResponseReasoningItemto use the correct structure withid,summary, andtype="reasoning"fieldsResponseReasoningSummaryPartAddedEventto includesummary_indexparameter and use a dictionary for thepartparameterResponseReasoningSummaryTextDeltaEventto includesummary_indexparameterResponseReasoningSummaryPartDoneEventto includesummary_indexand use a dictionary forpartSummaryobject is accessed in tests (using.textproperty instead of subscript notation)chatcmpl_converter.pyto use theSummaryclass instead of a dictionary for better handlignFixes #494