Skip to content

Conversation

pap-openai
Copy link
Collaborator

adding ripgrep dependency to make codex job execution faster/better

Copy link

@dylan-hurd-oai dylan-hurd-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pap-openai thanks for adding this! just double-checking since I didn't see it in the PR description, have we validated this change in a github action anywhere? I would expect it to be safe but couldn't hurt to test

Added ripgrep into the recommendation job, modified prompts to use ripgrep. Added more checks and validation for schemas in resolution.
@jonlim-openai
Copy link
Contributor

@dylan-hurd-oai I have added ripgrep to be included as part of the libraries included but there are no matching patterns for the repo that I am working on

Patterns are based on:

  rg -n -f /tmp/rg-patterns.txt -S --hidden --no-ignore-vcs \
    -g '!**/*.spec.ts' -g '!**/test/**' -g '!**/cypress/**' \
    -g '!**/assets/**' -g '!**/*.map' -g '!**/*.min.*' \
    -g '!**/screenshots/**' -g '!**/*.{gif,jpg,png,svg,ico,mp4}' \
    --no-heading --max-count 100 | head -n 100 > artifacts/hotspots_samples.txt || true
    
  rg -c -f /tmp/rg-patterns.txt -S --hidden --no-ignore-vcs \
    -g '!**/*.spec.ts' -g '!**/test/**' -g '!**/cypress/**' \
    -g '!**/assets/**' -g '!**/*.map' -g '!**/*.min.*' \
    -g '!**/screenshots/**' -g '!**/*.{gif,jpg,png,svg,ico,mp4}' \
    --no-messages | sort -t: -k2,2nr | head -n 50 > artifacts/hotspots_summary.txt || true
    
 In my CI file - let me  know if i am missing anything out

@jonlim-openai
Copy link
Contributor

-g '!**/*.spec.ts' -g '!**/test/**' -g '!**/cypress/**' \
-g '!**/assets/**' -g '!**/*.map' -g '!**/*.min.*' \
-g '!**/screenshots/**' -g '!**/*.{gif,jpg,png,svg,ico,mp4}' \
--no-messages | sort -t: -k2,2nr | head -n 50 > artifacts/hotspots_summary.txt || true
Copy link

@dylan-hurd-oai dylan-hurd-oai Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonlim-openai what are we using this for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a filter to ignore those types of file paths

@dylan-hurd-oai
Copy link

dylan-hurd-oai commented Sep 10, 2025

but there are no matching patterns for the repo that I am working on

This is purely a change to our installation method to address openai/codex#2501 - I would expect no direct change in behavior, just a fewer error reports from customers when using our cookbook

@jonlim-openai
Copy link
Contributor

The job runs to completion with no issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants