-
Notifications
You must be signed in to change notification settings - Fork 354
Update paging APIs to use updated SCM types #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joseharriaga
merged 75 commits into
openai:main
from
annelo-msft:oai-pageenumerator-pattern
Jul 23, 2024
Merged
Update paging APIs to use updated SCM types #105
joseharriaga
merged 75 commits into
openai:main
from
annelo-msft:oai-pageenumerator-pattern
Jul 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using general helpers
… using general helpers
…avor of generalized helpers
…s an abstract type
trrwilson
reviewed
Jul 22, 2024
trrwilson
reviewed
Jul 22, 2024
trrwilson
reviewed
Jul 22, 2024
examples/Assistants/Example03_ListAssistantsWithPaginationAsync.cs
Outdated
Show resolved
Hide resolved
trrwilson
reviewed
Jul 22, 2024
trrwilson
reviewed
Jul 22, 2024
trrwilson
approved these changes
Jul 22, 2024
annelo-msft
commented
Jul 23, 2024
annelo-msft
commented
Jul 23, 2024
joseharriaga
approved these changes
Jul 23, 2024
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In System.ClientModel 1.1.0-beta.5,
PageableCollection<T>was changed toPageCollection<T>to better align convenience and protocol methods.This PR upgrades the OpenAI library to SCM 1.1.0-beta.5, and manually implements internal types that will be generated from TypeSpec API specification in the future. Specifically, it:
PageCollection<T>orAsyncPageCollection<T>from convenience methodsXxCollectionOptionstypes that describe the paginated collection to be returnedIEnumerable<ClientResult>orIAsyncEnumerable<ClientResult>from protocol methods, representing a collection of service responses, where each corresponds to a page of results returned from the paginated endpointTypes that are intended to be output by the generator have been added in a temporary folder called
To.Be.Generated.