Fixes to Assistant, VectorStore client methods #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseharriaga
reviewed
Jul 9, 2024
joseharriaga
approved these changes
Jul 9, 2024
trrwilson
force-pushed
the
user/travisw/2024-06-17-assistant-fixes
branch
from
e632c23 to
8c994fa
Compare
joseharriaga
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssistantClientandVectorStoreClienthave optionalCancellationTokens added as method parameters, including the typed instance convenience overloads[EditorBrowsable(EditorBrowsableState.Never)]attributes toAssistantClientprotocol methods, improving strongly typed convenience method discoverabilitymax_num_resultsproperty forfile_searchnot being serialized/deserialized