Skip to content

Expose ResponseContentPart.InputImageUrl #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
crickman wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Expose ResponseContentPart.InputImageUrl #874

crickman wants to merge 10 commits into from

Conversation

@crickman
Copy link
Contributor

@crickman crickman commented Dec 12, 2025 •
edited by jsquire
Loading

Expose InternalItemContentInputImage.ImageUrl as public property: ResponseContentPart.InputImageUrl

Added smoke validation all public ResponseContentPart usage and serialization

closes #875

@crickman crickman mentioned this pull request Dec 12, 2025
Open
@jsquire jsquire added the community-contribution Community members are working on the issue label Dec 13, 2025
@jsquire
Copy link
Collaborator

jsquire commented Dec 13, 2025

Hi @crickman. Thanks very much for your contribution and your interest in improving the OpenAI developer experience. As discussed in #875, I think the proposed change aligns with the local and upstream REST API specs and agree this should be public. We appreciate your thorough and comprehensive approach to test validation. The implementation looks good to me.

I'm going to ask @joseharriaga to make the final call, as he'll have a more complete understanding of the historical context.

@jsquire jsquire added the area: responses This item is related to Responses label Dec 13, 2025
@actions-user
Update @typespec/http-client-csharp to 1.0.0-alpha.20251212.3
dd2f178 
- Updated @typespec/http-client-csharp from 1.0.0-alpha.20251125.5 to 1.0.0-alpha.20251212.3
- Updated Microsoft.TypeSpec.Generator.ClientModel from 1.0.0-alpha.20251125.5 to 1.0.0-alpha.20251212.3
- Regenerated OpenAI SDK code with new generator version
- Updated centrally managed package-lock.json file with new dependency versions
@christothes
Copy link
Collaborator

christothes commented Dec 15, 2025

Hi @crickman - Please run the Export-API script to update the public API surface file.

@crickman
Copy link
Contributor Author

crickman commented Dec 15, 2025

@christothes

Hi @crickman - Please run the Export-API script to update the public API surface file.

I'm getting this error:

&: C:\Users\crickman\source\repos\openai-fork\scripts\Export-Api.ps1:234
Line |
 234 |      & genapi @genapiArgs
     |        ~~~~~~
     | The term 'genapi' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Is there a module I need to install (type-spec related maybe)?

@christothes
Copy link
Collaborator

christothes commented Dec 15, 2025

@christothes

Hi @crickman - Please run the Export-API script to update the public API surface file.

I'm getting this error:

&: C:\Users\crickman\source\repos\openai-fork\scripts\Export-Api.ps1:234
Line |
 234 |      & genapi @genapiArgs
     |        ~~~~~~
     | The term 'genapi' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Is there a module I need to install (type-spec related maybe)?

I think you can grab it from here https://github.com/dotnet/sdk/tree/main/src/Compatibility/GenAPI

@crickman
Copy link
Contributor Author

crickman commented Dec 15, 2025

@christothes - Updated

@crickman
Copy link
Contributor Author

crickman commented Dec 18, 2025

Unclear why Build action is failing. I've ran tests locally in Release configuration:
image

Did noticed that related tests are marked as flaky. Others seem affected as well: https://github.com/openai/openai-dotnet/actions/workflows/release.yml

actions-user and others added 2 commits December 22, 2025 09:30
@actions-user
Update @typespec/http-client-csharp to 1.0.0-alpha.20251219.2
ef26ac3 
- Updated @typespec/http-client-csharp from 1.0.0-alpha.20251125.5 to 1.0.0-alpha.20251219.2
- Updated Microsoft.TypeSpec.Generator.ClientModel from 1.0.0-alpha.20251125.5 to 1.0.0-alpha.20251219.2
- Regenerated OpenAI SDK code with new generator version
- Updated centrally managed package-lock.json file with new dependency versions
@crickman
Merge branch 'openai:main' into main
9190c66
This was referenced Dec 23, 2025
Closed
Open
@crickman
Merge pull request #2 from crickman/typespec/update-http-client-cshar…
1d1bc82 
…p-1.0.0-alpha.20251219.2

Succeeded with Issues: Update @typespec/http-client-csharp to 1.0.0-alpha.20251219.2
@crickman
Merge branch 'main' into typespec/update-http-client-csharp-1.0.0-alp…
3d03d66 
…ha.20251212.3
@crickman
Merge pull request #1 from crickman/typespec/update-http-client-cshar…
ec08ded 
…p-1.0.0-alpha.20251212.3

Succeeded with Issues: Update @typespec/http-client-csharp to 1.0.0-alpha.20251212.3
Copilot AI mentioned this pull request Jan 5, 2026
Merged
Copilot AI added a commit to dotnet/extensions that referenced this pull request Jan 5, 2026
@stephentoub
Add support for InputImageUrl via reflection in OpenAIResponsesChatCl…
fcc1f5d 
…ient

This adds handling for the `image_url` property in `input_image` response content.
Since the OpenAI SDK doesn't yet expose this property publicly, we access it via:
1. Direct property reflection (for when the property becomes public)
2. SerializedAdditionalRawData dictionary (for internal SDK storage)
3. IJsonModel serialization fallback (to extract from JSON representation)

See: openai/openai-dotnet#874

Includes a unit test that validates the image URL propagates through responses.

Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
@joseharriaga
Copy link
Collaborator

joseharriaga commented Jan 5, 2026

@crickman : It appears that your package.json and package-lock.json are out of sync, causing the "CodeGen Validation" check to fail. You shouldn't need to change those files as part of this PR, so I would recommend reverting those changes for simplicity. 🙂

joseharriaga
joseharriaga requested changes Jan 8, 2026
View reviewed changes
codegen/package.json
"@typespec/http-client-csharp": "1.0.0-alpha.20251125.5",
"@typespec/openapi": "1.6.0"
"@typespec/http": "1.7.0",
"@typespec/http-client-csharp": "1.0.0-alpha.20251212.3",
Copy link
Collaborator

@joseharriaga joseharriaga Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package has been updated to version 1.0.0-alpha.20251223.2, so this part of the PR can be reverted. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseharriaga joseharriaga joseharriaga requested changes

@jsquire jsquire jsquire approved these changes

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

Requested changes must be addressed to merge this pull request.

Assignees

@joseharriaga joseharriaga

Labels

area: responses This item is related to Responses community-contribution Community members are working on the issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] ImageUrl not exposed on ResponseContentPart for CreateInputImagePart

5 participants

@crickman @jsquire @christothes @joseharriaga @actions-user