Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the issue with recursive and nested Zod schemas #990

Closed
wants to merge 1 commit into from
Closed

Resolve the issue with recursive and nested Zod schemas #990

wants to merge 1 commit into from

Conversation

ZijiaZhang
Copy link
Contributor

@ZijiaZhang ZijiaZhang commented Aug 13, 2024 •
edited
Loading

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Resolve the issue with recursive and nested Zod schemas.
  • Add test for recursive json schema
  • Fix the test with nested schema
  • Fix the issue that the 'definitions' in the defaultOptions are not reset between function executions.

Additional context & links

#978

@ZijiaZhang ZijiaZhang requested a review from a team as a code owner August 13, 2024 04:55
@RobertCraigie RobertCraigie mentioned this pull request Aug 13, 2024
Merged
@RobertCraigie
Copy link
Collaborator

Thanks so much @ZijiaZhang! I really appreciate it.

I merged your changes separately in #992 as I wanted to make a couple minor style changes.

RobertCraigie referenced this pull request Aug 13, 2024
@RobertCraigie @stainless-app
fix(helpers/zod): nested union schema extraction (#979)
510c866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZijiaZhang @RobertCraigie