Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional ClientTimeout parameter support on async API calls - sock_read, sock_connect #336

Closed
suhjohn opened this issue Mar 23, 2023 · 2 comments
Labels
fixed in v1 Issues addressed by the v1 beta

Comments

@suhjohn
Copy link

suhjohn commented Mar 23, 2023

Describe the feature or improvement you're requesting

Want a logic to retry API if sock_read on stream is not working in <2 seconds. Sometimes this happens on a web-server due to various issues with the requesting library (requests.request / aiohttp). Currently only

            timeout = aiohttp.ClientTimeout(
                connect=request_timeout[0],
                total=request_timeout[1],
            )

is supported. Perhaps accepting additional lengths on request_timeout, or adding a new kwarg for timeout object, or accepting a dictionary instead a tuple on request_timeout would be helpful.

Additional context

No response

@suhjohn suhjohn changed the title ClientTimeout object support - sock_read, sock_connect ClientTimeout support on all API calls - sock_read, sock_connect Mar 23, 2023
@suhjohn suhjohn changed the title ClientTimeout support on all API calls - sock_read, sock_connect Additional ClientTimeout parameter support on async API calls - sock_read, sock_connect Mar 23, 2023
@ShantanuNair
Copy link

@suhjohn I'm exploring this issue currently. Is this PR relevant here?
#387

@ShantanuNair
Copy link

@suhjohn Apparently fixed in the v1.0.0 beta: #631 (comment)

@RobertCraigie RobertCraigie added the fixed in v1 Issues addressed by the v1 beta label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in v1 Issues addressed by the v1 beta
Projects
None yet
Development

No branches or pull requests

3 participants