feat(client): add ._request_id property to object responses #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stainless-bot
force-pushed
the
next
branch
2 times, most recently
from
c6d1822 to
06bd42e
Compare
stainless-app
bot
force-pushed
the
next
branch
from
06bd42e to
48026f3
Compare
stainless-bot
force-pushed
the
robert/add-request-id
branch
3 times, most recently
from
58eeaf2 to
e3493e2
Compare
stainless-app
bot
force-pushed
the
next
branch
from
351af85 to
73f9fda
Compare
Contributor
|
Nice - this seems like a good thing to do to all the SDKs. |
Collaborator
Author
|
yup I'm working on this for the Node SDK as well :) |
RahulVadisetty91
left a comment
RahulVadisetty91
left a comment
There was a problem hiding this comment.
This script is well-structured and extremely useful for anyone working with Pydantic models, especially when managing compatibility between Pydantic v1 and v2.
athyuttamre
approved these changes
Sep 16, 2024
stainless-bot
force-pushed
the
robert/add-request-id
branch
2 times, most recently
from
eeaa015 to
d2f6e40
Compare
athyuttamre
reviewed
Sep 17, 2024
stainless-bot
force-pushed
the
robert/add-request-id
branch
from
d2f6e40 to
c42e30e
Compare
stainless-bot
force-pushed
the
robert/add-request-id
branch
from
c42e30e to
e6b7f13
Compare
Merged
stainless-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
|
Is it possible to log the request id for async streaming as well? Right now I get the error 'AsyncStream' object has no attribute '_request_id'. |
Collaborator
Author
|
@wilson97 right now you can do this stream = await client.chat.completions.create(..., stream=True)
stream.response.headers.get('x-request-id') # req_xxxbut I don't see a reason not to add a |
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.