Skip to content

Fix/2708 #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/2708 #2713

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6b7b92
added closing bufor in upload_file_chunked
jasiecky Oct 29, 2025
bc52d2f
refactor
jasiecky Oct 29, 2025
974158e
Merge branch 'main' into fix/2709
jasiecky Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/openai/resources/uploads/uploads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,9 @@ def upload_file_chunked(
log.info("Uploaded part %s for upload %s", part.id, upload.id)
part_ids.append(part.id)
except Exception:
buf.close()
raise
finally:
buf.close()

return self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5)

Expand Down Expand Up @@ -466,8 +467,9 @@ async def upload_file_chunked(
log.info("Uploaded part %s for upload %s", part.id, upload.id)
part_ids.append(part.id)
except Exception:
buf.close()
raise
finally:
buf.close()

return await self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5)

Expand Down