added {model: string;} arg to client.connect()
#112
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was, the library did not allow setting the model used by the realtime API. This commit should fix that by making the model a mandatory argument of the `client.connect` method. The model must be passed to `connect` as a string property called `model` in an object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was, the library did not allow setting the
model used by the realtime API.
This commit should fix that by making the model
a mandatory argument of the
client.connectmethod.The model must be passed to
connectas a string property calledmodelin an object.E.g.
I've made the argument mandatory because if you use the wrong model your wallet can suffer quickly.
The
minimodel is like 10x less expensive. Just sayin'...