fix: preserve original event timestamps #525
Conversation
fix issue where timestamps would update on each re-render by adding timestamp to events when they are created/received instead of render time
| setEvents((prev) => [JSON.parse(e.data), ...prev]); | ||
| const event = JSON.parse(e.data); | ||
| if (!event.timestamp) { | ||
| event.timestamp = new Date().toLocaleTimeString(); |
There was a problem hiding this comment.
Could we use new Date().toISOString() instead of toLocaleTimeString()? The current approach is locale-dependent, which might lead to inconsistent formats across different environments. Using toISOString() ensures a standardized UTC format and includes milliseconds.
There was a problem hiding this comment.
✅ Better Alternative
event.timestamp = new Date().toISOString();
• Consistent format (UTC)
• Includes milliseconds
• ISO 8601 standard (perfect for logs, APIs, databases)
⸻
Suggested Review Feedback:
Thanks @nsaiprakash90 — totally agree on the timestamp standard. Locale-based formats could easily create parsing or display bugs down the line, especially in multi-region apps.
Recommend switching:
event.timestamp = new Date().toISOString();
That way we keep all timestamps clean, comparable, and timezone-safe.
– Hung Minh Vo // AIC-HMV Core Maintainer
Ready for merge? Say the word and I’ll help draft the pull request or resolve review.
…istence fix: preserve original event timestamps
|
Hey, I noticed this in the latest pull: |
AIC-HMV
left a comment
AIC-HMV
left a comment
There was a problem hiding this comment.
Ready for merge? Say the word and I’ll help draft the pull request or resolve review.
4 participants
fix issue where timestamps would update on each re-render by adding timestamp to events when they are created/received instead of render time