-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: Split code rust, for run as python lib and rust lib #167
base: main
Are you sure you want to change the base?
Conversation
9db8696
to
1250302
Compare
Correcting sdist, they change this:
for this:
|
Hi @hauntsaninja, this is a first version, without changes in the core, only separating the rust in 2, a rs-tiktoken thinking in creating the crate and another py-tiktoken that is the binding for python. Then you can think about creating more versions like one for java something like jvm-tiktoken because it is really for you to use it from java, scala, etc, but first refine the core that should be in rs-tiktoken. |
@hauntsaninja do you think I should add more changes to this PR to have a fully functional rust version? |
The MANIFEST.in is fixed and I also separated the workflows for aarch64 into 2:
y
that's the way it is: because I see that it is giving an error commits before my changes, this happens in arch64 but the versions that use musl instead of glibc. Should we deactivate the musl? is there really a need to support aarch64 with musl ? |
2a19ff3
to
145a88e
Compare
What happen? Did I make a mistake? any comments? Is there anything I need to change in order for my PR to be considered? |
This commit restructures the project from a single-crate workspace into a multi-crate workspace, dividing it into 'rs-tiktoken' and 'py-tiktoken'. This is done to improve the clarity of the organization of the codebase and make the Rust and Python modules separate for easier code maintenance. The setup.py is also updated to reflect these changes in the directory structure. Refs: openai#24
Split the code rust, for run as python lib and rust lib, to be able to publish in both crates and pypi.
Fixes #24