feat: Add option TIKTOKEN_FORCE_CACHE #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add taking into account the env var TIKTOKEN_FORCE_CACHE. When TIKTOKEN_FORCE_CACHE is set to "1", tiktoken will read BPE files only from the local cache. It allows us to have control over when BPE files are downloaded from the internet.
jd
reviewed
Jul 28, 2023
| @@ -44,7 +44,9 @@ def read_file_cached(blobpath: str) -> bytes: | |||
| if os.path.exists(cache_path): | |||
| with open(cache_path, "rb") as f: | |||
| return f.read() | |||
|
|
|||
| elif os.environ.get("TIKTOKEN_FORCE_CACHE") == "1": | |||
There was a problem hiding this comment.
Yes, why not. I will let the maintainers decide.
There was a problem hiding this comment.
From my pov, this should be passed via the library API not an os.environ.
There was a problem hiding this comment.
It was to keep the spirit of the function that uses os.environ to retrieve the cache_dir
jd
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add taking into account the env var TIKTOKEN_FORCE_CACHE. When TIKTOKEN_FORCE_CACHE is set to "1", tiktoken will read BPE files only from the local cache.
It allows us to have control over when BPE files are downloaded from the internet.