word timing tweaks #1559
Merged
word timing tweaks #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you explain this commit? |
taylorchu
commented
Jul 30, 2023
whisper/timing.py
Outdated
| @@ -215,6 +215,8 @@ def find_alignment( | |||
|
|
|||
| words, word_tokens = tokenizer.split_to_word_tokens(text_tokens + [tokenizer.eot]) | |||
| word_boundaries = np.pad(np.cumsum([len(t) for t in word_tokens[:-1]]), (1, 0)) | |||
| if len(word_boundaries) <= 1: | |||
There was a problem hiding this comment.
This fixes crashes because word_boundaries could be empty.
>>> word_tokens = [[5, 1],[3,2,1], [1]]
>>> np.pad(np.cumsum([len(t) for t in word_tokens[:-1]]), (1, 0))
array([0, 2, 5])
>>> word_tokens = []
>>> np.pad(np.cumsum([len(t) for t in word_tokens[:-1]]), (1, 0))
array([0.])
taylorchu
commented
Jul 30, 2023
| @@ -297,8 +299,6 @@ def add_word_timestamps( | |||
| # hack: truncate long words at sentence boundaries. | |||
| # a better segmentation algorithm based on VAD should be able to replace this. | |||
| if len(word_durations) > 0: | |||
| median_duration = np.median(word_durations) | |||
There was a problem hiding this comment.
I added comments to make it clearer. |
|
@jongwook could you take a look at this? thanks! |
|
ping |
|
thanks! |
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
* word timing tweaks * comment on eot * clearer comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.