Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Illogical "Avoid computing higher temperatures on no_speech" #1903

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix: Illogical "Avoid computing higher temperatures on no_speech" #1903

wants to merge 2 commits into from

Commits on Jan 4, 2024

  1. Bugfix: Illogical "Avoid computing higher temperatures on no_speech" 

    Bugfix for openai#1279

It's "silence" when decoding has failed due to `compression_ratio_threshold` too, when further down the code it's not "silence" anymore.

"Silence" should be only when decoding has failed due to `logprob_threshold`.

Like described there:
https://github.com/openai/whisper/blob/8bc8860694949db53c42ba47ddc23786c2e02a8b/whisper/transcribe.py#L421

And in code there:
https://github.com/openai/whisper/blob/8bc8860694949db53c42ba47ddc23786c2e02a8b/whisper/transcribe.py#L243-L251
    @Purfview
    Purfview committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e7d46c9 View commit details
    Browse the repository at this point in the history

  2. Fix if "logprob_threshold=None"

    @Purfview
    Purfview committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2a7e12f View commit details
    Browse the repository at this point in the history